Added a username reminder for admins - #1122
Conversation
|
Note the checks failed due to #1123. |
|
I tried this and it seems to work. Could you change the target branch to be release-3..7.0 so that it can be merged into that one? Thanks |
1. Fixed field type 1. Added fields to enter address and get a username reminder
To avoid conflict with phplist/admin/ui/phplist-ui-bootlist/css/style.css margin-top: 30px (this theme wasn't updated in years)
Modeled on function sendAdminPasswordToken
Added fields and infrastructure to allow sending a username reminder
|
Thanks for changing the target branch. Can you also rebase on main? It would be nice if I can do that, but unfortunately I can't |
This feels like a quest. I've just synced my fork, is that what you meant? Meanwhile, this time most checks failed due to #1136. |
|
Yeah, the trouble of working across different places. Git is supposed to make that easier. I do the the diff is too large, eg https://github.com/phpList/phplist3/pull/1122/changes I'll see if I can reset this, but if you can check a rebase, that would be better. At least then the changes will be attributed to you and not me. |
Can you instruct me exactly what to do preferably in the UI? |
c9f51f9 to
55301bf
Compare
|
Sorry for the confusion. I initially assumed this PR would be merged into main, so I asked to pull in commits from main. I've now rebased the branch and removed commits from main, leaving only the changes that belong to this PR |
Okay, so waiting for further feedback/merge. |
4 participants
Description
Although password reminder insecurely mentions the username, it does it without using the word "username", but either way there should be an independent username reminder without the possibility to accidentally modify the database and change the password.
As a side fix, the e-mail field was defined as text rather than email.
All of this was done by adding support in:
I didn't duplicate
public_html/lists/admin/tests/subscriber_password.phpsince it's meant for end-users while this task is for admins.Note this requires the following new translations:
For
public_html/lists/admin/tests/admin/index.php:For
public_html/lists/admin/tests/admin/lib.php:For
public_html/lists/admin/tests/admin/login.php:Related Issue
N/A
Screenshots (if appropriate):